feat: Adopt resumption feature of online data mixing #617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mehant Kammakomati <[email protected]>
kmehant
requested review from
aluu317,
anhuong,
dushyantbehl and
fabianlim
as code owners
|
Thanks for making a pull request! 😃 |
Signed-off-by: Mehant Kammakomati <[email protected]>
Signed-off-by: Mehant Kammakomati <[email protected]>
Signed-off-by: Mehant Kammakomati <[email protected]>
dushyantbehl
reviewed
Oct 8, 2025
|
|
||
| resume_from_checkpoint = None | ||
| if train_args.output_dir: | ||
| os.makedirs(train_args.output_dir, exist_ok=True) |
Collaborator
There was a problem hiding this comment.
Why do we need to make the output directory doesn't the trainer make it already?
Collaborator
Author
There was a problem hiding this comment.
get_last_checkpoint has a dependency of having output_dir available, it was just the code that already exists I move it above in this function :)
Collaborator
Author
There was a problem hiding this comment.
related to this failing test - https://github.com/foundation-model-stack/fms-hf-tuning/actions/runs/18341924401
Signed-off-by: Mehant Kammakomati <[email protected]>
kmehant
force-pushed
the
odm-plugin-resume-3
branch
from
7df2365 to
82495d3
Compare
Signed-off-by: Mehant Kammakomati <[email protected]>
Signed-off-by: Mehant Kammakomati <[email protected]>
Signed-off-by: Mehant Kammakomati <[email protected]>
Signed-off-by: Mehant Kammakomati <[email protected]>
dushyantbehl
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In this PR, we move construction of the
resume_from_checkpointto the top of the function so that it can used in odm_config. Further depends on merge of foundation-model-stack/fms-acceleration#155